This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
feat: support filecoin hamt in same schema #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i believe they are compatible for the forthcoming actor hamts in spec-actors v3 |
|
Yes, luckily their v3 now uses a kinded union for their equivalent to our Element :) Something like what you did here would be useful if we want to support filecoin HAMTs older than v3 with our ADL, but as far as I know that's not planned right now. So I think we should close this PR for the time being, without losing the diff in case we want to dig it up later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to support the Filecoin HAMT in the same schema. We should discuss the implications of this in the IPLD call because I’m not sure how well a double union will work in practice.